linux-kernel - Re: [PATCH] perf core: Fix some kernel-doc warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YK3zHAdIQZ9GPhfg@gmail.com>
Date:   Wed, 26 May 2021 09:05:00 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Haocheng Xie <xiehaocheng.cn@...il.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, namhyung@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf core: Fix some kernel-doc warnings.


* Haocheng Xie <xiehaocheng.cn@...il.com> wrote:

> Fix the following W=1 kernel build warning(s):
> kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
> kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
> kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
> kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'
> 
> Signed-off-by: Haocheng Xie <xiehaocheng.cn@...il.com>

Even with your two patches there's still W=1 warnings remaining in 
kernel/events/:

  kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
  kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'

Could you please fix all of them, and send them as a 3-patch series? 

Doesn't make much sense to just partially fix W=1 warnings in a subsystem.

Thanks,

	Ingo