linux-kernel - Re: [PATCH 18/43] KVM: x86: Consolidate APIC base RESET initialization code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeT=FwYkFvxbKPxtMAw2An_HLQxk5LOuFX2JGQ9qn_3QVy94Q@mail.gmail.com>
Date:   Wed, 26 May 2021 00:04:50 -0700
From:   Reiji Watanabe <reijiw@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/43] KVM: x86: Consolidate APIC base RESET
 initialization code

On Fri, Apr 23, 2021 at 5:51 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> Consolidate the APIC base RESET logic, which is currently spread out
> across both x86 and vendor code.  For an in-kernel APIC, the vendor code
> is redundant.  But for a userspace APIC, KVM relies on the vendor code
> to initialize vcpu->arch.apic_base.  Hoist the vcpu->arch.apic_base
> initialization above the !apic check so that it applies to both flavors
> of APIC emulation, and delete the vendor code.
>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Reiji Watanabe <reijiw@...gle.com>