linux-kernel - Re: [PATCH 1/7] arm64: dts: qcom: Add PMI8996 DTSI file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9aa000f8-3790-11ca-ab85-245146422938@somainline.org>
Date:   Wed, 26 May 2021 11:29:38 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] arm64: dts: qcom: Add PMI8996 DTSI file

Hi,


> So I'm supposed to include this and the pmi8994? I was expecting an
> include of pmi8994.dtsi from here and then some override of the
> necessary properties.

This way we would have to get three dts files for each device:

one for device-common stuff, one including pmi8994 and one

including pmi8996. Otherwise pmi8994 contents would be included

twice, as the "base" device dt already includes pmi8994.


If you check how I solved that on Tone, I just took the pmi8994-equipped

phone dt as a baseline and only included this small dtsi as an overlay on top.


Konrad