linux-kernel - Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 May 2021 12:09:21 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     Gowtham Tammana <g-tammana@...com>, Suman Anna <s-anna@...com>,
        bcousson@...libre.com, robh+dt@...nel.org,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Nisanth Menon <nm@...com>
Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node

* Grygorii Strashko <grygorii.strashko@...com> [210527 09:03]:
> On 27/05/2021 08:48, Tony Lindgren wrote:
> > But let's keep the target-module@...000 here as it puts it in the right
> > location rather than directly on the ocp. Let's mark it with
> > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only
> > available on dra74x. So similar to what you had in your v1 patch, except
> > disabled.
> 
> My preference would be not to mix SoC variant specific modules in common module,
> and fix dra74x instead by placing usb4 node in proper place:
> 
> &l4_per3 {						/* 0x48800000 */
> 	segment@0 {	
> -->

Yeah that's even better, and leaves out status = "disabled".
Sounds good to me.

Regards,

Tony