linux-kernel - Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd903d6a-2894-fc39-e431-5dfed04a3604@ti.com>
Date:   Thu, 27 May 2021 12:03:24 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Tony Lindgren <tony@...mide.com>,
        Gowtham Tammana <g-tammana@...com>
CC:     Suman Anna <s-anna@...com>, <bcousson@...libre.com>,
        <robh+dt@...nel.org>, <linux-omap@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, Nisanth Menon <nm@...com>
Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node

Hi Tony,

On 27/05/2021 08:48, Tony Lindgren wrote:
> Hi,
> 
> * Gowtham Tammana <g-tammana@...com> [210526 21:30]:
>> diff --git a/arch/arm/boot/dts/am5718.dtsi b/arch/arm/boot/dts/am5718.dtsi
>> index ebf4d3cc1cfb..6d7530a48c73 100644
>> --- a/arch/arm/boot/dts/am5718.dtsi
>> +++ b/arch/arm/boot/dts/am5718.dtsi
>> @@ -17,17 +17,13 @@ / {
>>    * VCP1, VCP2
>>    * MLB
>>    * ISS
>> - * USB3, USB4
>> + * USB3
>>    */
>>   
>>   &usb3_tm {
>>   	status = "disabled";
>>   };
>>   
>> -&usb4_tm {
>> -	status = "disabled";
>> -};
>> -
>>   &atl_tm {
>>   	status = "disabled";
>>   };
> 
> The above makes sense as usb4 is only on dra74x and should not be even
> available otherwise.
> 
>> diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
>> index 149144cdff35..648d23f7f748 100644
>> --- a/arch/arm/boot/dts/dra7-l4.dtsi
>> +++ b/arch/arm/boot/dts/dra7-l4.dtsi
>> @@ -4129,28 +4129,6 @@ usb3: usb@...00 {
>>   			};
>>   		};
>>   
>> -		usb4_tm: target-module@...000 {		/* 0x48940000, ap 75 3c.0 */
>> -			compatible = "ti,sysc-omap4", "ti,sysc";
>> -			reg = <0x140000 0x4>,
>> -			      <0x140010 0x4>;
>> -			reg-names = "rev", "sysc";
>> -			ti,sysc-mask = <SYSC_OMAP4_DMADISABLE>;
>> -			ti,sysc-midle = <SYSC_IDLE_FORCE>,
>> -					<SYSC_IDLE_NO>,
>> -					<SYSC_IDLE_SMART>,
>> -					<SYSC_IDLE_SMART_WKUP>;
>> -			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
>> -					<SYSC_IDLE_NO>,
>> -					<SYSC_IDLE_SMART>,
>> -					<SYSC_IDLE_SMART_WKUP>;
>> -			/* Domains (P, C): l3init_pwrdm, l3init_clkdm */
>> -			clocks = <&l3init_clkctrl DRA7_L3INIT_USB_OTG_SS4_CLKCTRL 0>;
>> -			clock-names = "fck";
>> -			#address-cells = <1>;
>> -			#size-cells = <1>;
>> -			ranges = <0x0 0x140000 0x20000>;
>> -		};
>> -
> 
> But let's keep the target-module@...000 here as it puts it in the right
> location rather than directly on the ocp. Let's mark it with
> status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only
> available on dra74x. So similar to what you had in your v1 patch, except
> disabled.

My preference would be not to mix SoC variant specific modules in common module,
and fix dra74x instead by placing usb4 node in proper place:

&l4_per3 {						/* 0x48800000 */
	segment@0 {	
-->

> 
>> diff --git a/arch/arm/boot/dts/dra71x.dtsi b/arch/arm/boot/dts/dra71x.dtsi
>> index cad0e4a2bd8d..9c270d8f75d5 100644
>> --- a/arch/arm/boot/dts/dra71x.dtsi
>> +++ b/arch/arm/boot/dts/dra71x.dtsi
>> @@ -11,7 +11,3 @@
>>   &rtctarget {
>>   	status = "disabled";
>>   };
>> -
>> -&usb4_tm {
>> -	status = "disabled";
>> -};
>> diff --git a/arch/arm/boot/dts/dra72x.dtsi b/arch/arm/boot/dts/dra72x.dtsi
>> index d403acc754b6..f3e934ef7d3e 100644
>> --- a/arch/arm/boot/dts/dra72x.dtsi
>> +++ b/arch/arm/boot/dts/dra72x.dtsi
>> @@ -108,7 +108,3 @@ &pcie1_ep {
>>   &pcie2_rc {
>>   	compatible = "ti,dra726-pcie-rc", "ti,dra7-pcie";
>>   };
>> -
>> -&usb4_tm {
>> -	status = "disabled";
>> -};
> 
> Then the above change can be kept.
> 
>> diff --git a/arch/arm/boot/dts/dra74x.dtsi b/arch/arm/boot/dts/dra74x.dtsi
>> index e1850d6c841a..60f2ab8d34d5 100644
>> --- a/arch/arm/boot/dts/dra74x.dtsi
>> +++ b/arch/arm/boot/dts/dra74x.dtsi
>> @@ -49,7 +49,7 @@ dsp2_system: dsp_system@...00000 {
>>   			reg = <0x41500000 0x100>;
>>   		};
>>   
>> -		target-module@...40000 {
>> +		usb4_tm: target-module@...40000 {
>>   			compatible = "ti,sysc-omap4", "ti,sysc";
>>   			reg = <0x48940000 0x4>,
>>   			      <0x48940010 0x4>;
> 
> And in dra74x.dtsi just set it enabled then :)


-- 
Best regards,
grygorii