linux-kernel - Re: [PATCH v1 08/28] leds: lgm-sso: Put fwnode in any case during ->probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210528100800.GF2209@amd>
Date:   Fri, 28 May 2021 12:08:00 +0200
From:   Pavel Machek <pavel@....cz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <marek.behun@....cz>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 08/28] leds: lgm-sso: Put fwnode in any case during
 ->probe()

Hi!

> @@ -734,10 +736,15 @@ static int sso_led_dt_parse(struct sso_led_priv *priv)
>  	if (fw_ssoled) {
>  		ret = __sso_led_dt_parse(priv, fw_ssoled);
>  		if (ret)
> -			return ret;
> +			goto err_child_out;
>  	}
>  
> +	fwnode_handle_put(fw_ssoled);
>  	return 0;
> +
> +err_child_out:
> +	fwnode_handle_put(fw_ssoled);
> +	return ret;
>  }

Just delete the return and you get the same effect, no? No need to
have two exits here.

BR,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)