linux-kernel - Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210528100906.GG2209@amd>
Date:   Fri, 28 May 2021 12:09:06 +0200
From:   Pavel Machek <pavel@....cz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Amireddy Mallikarjuna reddy 
        <mallikarjunax.reddy@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <marek.behun@....cz>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource
 cleanups

On Mon 2021-05-10 12:50:28, Andy Shevchenko wrote:
> The idea of managed resources that they will be cleaned up automatically
> and in the proper order. Remove explicit cleanups.

Are you really sure this is good idea with the regmap_update_bits in
between?

BR,
								Pavel

> ---
>  drivers/leds/blink/leds-lgm-sso.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c
> index e76be25480b4..a7f2e5436ba2 100644
> --- a/drivers/leds/blink/leds-lgm-sso.c
> +++ b/drivers/leds/blink/leds-lgm-sso.c
> @@ -606,16 +606,10 @@ static void sso_led_shutdown(struct sso_led *led)
>  {
>  	struct sso_led_priv *priv = led->priv;
>  
> -	/* unregister led */
> -	devm_led_classdev_unregister(priv->dev, &led->cdev);
> -
>  	/* clear HW control bit */
>  	if (led->desc.hw_trig)
>  		regmap_update_bits(priv->mmap, SSO_CON3, BIT(led->desc.pin), 0);
>  
> -	if (led->gpiod)
> -		devm_gpiod_put(priv->dev, led->gpiod);
> -
>  	led->priv = NULL;
>  }
>  

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)