linux-kernel - Re: [PATCH v1 02/28] leds: core: The -ENOTSUPP should never be seen by user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLDJWV4HYvBJYcq0@smile.fi.intel.com>
Date:   Fri, 28 May 2021 13:43:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Behún <marek.behun@....cz>,
        Abanoub Sameh <abanoubsameh8@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jacek Anaszewski <j.anaszewski@...sung.com>
Subject: Re: [PATCH v1 02/28] leds: core: The -ENOTSUPP should never be seen
 by user space

On Fri, May 28, 2021 at 12:03:39PM +0200, Pavel Machek wrote:
> On Mon 2021-05-10 12:50:19, Andy Shevchenko wrote:
> > Replace -ENOTSUPP by -EOPNOTSUPP when returning from exported function.
> > 
> > Fixes: 13ae79bbe4c2 ("leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting")
> > Cc: Jacek Anaszewski <j.anaszewski@...sung.com>
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Are you sure this is real problem?

(Potential) real problem, yes.

» This does not sound like an error
> path that should happen.

Before crafting this patch I have checked callers and _luckily_ they haven't
tested the returned code. But if any of the user decides to check -> real
problem.

-- 
With Best Regards,
Andy Shevchenko