linux-kernel - Re: [PATCH] PCI: Add const type for comparison function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210528191911.GA1513016@bjorn-Precision-5520>
Date:   Fri, 28 May 2021 14:19:11 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     bhelgaas@...gle.com, kernel test robot <lkp@...el.com>,
        "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: Add const type for comparison function parameter

On Sat, May 29, 2021 at 01:02:42AM +0800, Kai-Heng Feng wrote:
> Commit 4f0f586bf0c8 ("treewide: Change list_sort to use const pointers")
> added const on parameter "struct list_head *".
> 
> So add const to match the type.
> 
> Fixes: 276b15de5287 ("PCI: Coalesce host bridge contiguous apertures")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Squashed into "PCI: Coalesce host bridge contiguous apertures",
thanks!

> ---
>  drivers/pci/probe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index bf58e5dd1d82..bd862b612633 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -875,7 +875,8 @@ static void pci_set_bus_msi_domain(struct pci_bus *bus)
>  	dev_set_msi_domain(&bus->dev, d);
>  }
>  
> -static int res_cmp(void *priv, struct list_head *a, struct list_head *b)
> +static int res_cmp(void *priv, const struct list_head *a,
> +		   const struct list_head *b)
>  {
>  	struct resource_entry *entry1, *entry2;
>  
> -- 
> 2.31.1
>