linux-kernel - Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLIveGTHK5RjxtS+@kroah.com>
Date:   Sat, 29 May 2021 14:11:36 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in
 ffs_prepare_buffer()

On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote:
> A coccicheck run provided information like the following.
> 
> ./drivers/usb/gadget/function/f_fs.c:3832:9-16:
>  WARNING: ERR_CAST can be used with data
> 
> ffs_prepare_buffer() should return an ERR_PTR() encoded error
> code on failure.

It does return such a pointer today, so this statement does not make
much sense :(

And is this a v2 patch?  What changed from the previous version?

thanks,

greg k-h