linux-kernel - Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 May 2021 20:54:06 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <balbi@...nel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in
 ffs_prepare_buffer()

On 2021/5/29 20:11, Greg KH wrote:
> On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote:
>> A coccicheck run provided information like the following.
>>
>> ./drivers/usb/gadget/function/f_fs.c:3832:9-16:
>>  WARNING: ERR_CAST can be used with data
>>
>> ffs_prepare_buffer() should return an ERR_PTR() encoded error
>> code on failure.
> 
> It does return such a pointer today, so this statement does not make
> much sense :(

Yes, it does. This is just to remove explicit casts.

> 
> And is this a v2 patch?  What changed from the previous version?

Sorry, I forget to add version info.

> 
> thanks,
> 
> greg k-h
> .
>