linux-kernel - Re: [PATCH 4.4 35/54] ALSA: sb8: Add a comment note regarding an unused pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YLVYhlUl7coKfECd@sashalap>
Date:   Mon, 31 May 2021 17:43:34 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Takashi Iwai <tiwai@...e.de>,
        Atul Gopinathan <atulgopinathan@...il.com>
Subject: Re: [PATCH 4.4 35/54] ALSA: sb8: Add a comment note regarding an
 unused pointer

On Mon, May 31, 2021 at 10:36:38PM +0200, Pavel Machek wrote:
>Hi!
>
>> [ Upstream commit a28591f61b60fac820c6de59826ffa710e5e314e ]
>>
>> The field "fm_res" of "struct snd_sb8" is never used/dereferenced
>> throughout the sb8.c code. Therefore there is no need for any null value
>> check after the "request_region()".
>>
>> Add a comment note to make developers know about this and prevent any
>> "NULL check" patches on this part of code.
>>
>> Cc: Takashi Iwai <tiwai@...e.de>
>> Signed-off-by: Atul Gopinathan <atulgopinathan@...il.com>
>> Link: https://lore.kernel.org/r/20210503115736.2104747-36-gregkh@linuxfoundation.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This simply adds a comment... As I'm pretty sure anyone trying to
>"fix" this will try that on mainline, it is even very useful comment.
>
>That's something our documentation says we don't do in stable. I'd
>prefer it not to be in.

Now dropped, thanks!

-- 
Thanks,
Sasha