linux-kernel - Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35ef9495-df4e-ef3e-e730-c3708bbfe6bd@linux.microsoft.com>
Date:   Tue, 1 Jun 2021 12:49:46 -0700
From:   Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To:     Wei Liu <wei.liu@...nel.org>
Cc:     linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mikelley@...rosoft.com,
        viremana@...ux.microsoft.com, sunilmut@...rosoft.com,
        vkuznets@...hat.com, ligrassi@...rosoft.com, kys@...rosoft.com
Subject: Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr

On 5/29/2021 2:55 PM, Wei Liu wrote:
> On Fri, May 28, 2021 at 03:43:32PM -0700, Nuno Das Neves wrote:
> [...]
>>  int mshv_synic_init(unsigned int cpu)
>>  {
>>  	union hv_synic_simp simp;
>> @@ -30,7 +126,7 @@ int mshv_synic_init(unsigned int cpu)
>>  	*msg_page = memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT,
>>  			     HV_HYP_PAGE_SIZE,
>>                               MEMREMAP_WB);
>> -	if (!msg_page) {
>> +	if (!(*msg_page)) {
> 
> This hunk belongs to the previous patch in which you introduced this
> function, not this one.
> 
> Wei.
> 
Hmm I think I messed up a rebase. Thanks for catching it!