linux-kernel - Re: [PATCH 06/19] drivers/hv: create, initialize, finalize, delete partition hypercalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <612dbeb1-3edc-a46f-46d2-01acc622c307@linux.microsoft.com>
Date:   Tue, 1 Jun 2021 12:52:56 -0700
From:   Nuno Das Neves <nunodasneves@...ux.microsoft.com>
To:     Wei Liu <wei.liu@...nel.org>
Cc:     linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, mikelley@...rosoft.com,
        viremana@...ux.microsoft.com, sunilmut@...rosoft.com,
        vkuznets@...hat.com, ligrassi@...rosoft.com, kys@...rosoft.com
Subject: Re: [PATCH 06/19] drivers/hv: create, initialize, finalize, delete
 partition hypercalls



On 6/1/2021 12:59 AM, Wei Liu wrote:
> On Fri, May 28, 2021 at 03:43:26PM -0700, Nuno Das Neves wrote:
> [...]
>> diff --git a/arch/x86/include/uapi/asm/hyperv-tlfs.h b/arch/x86/include/uapi/asm/hyperv-tlfs.h
>> index 72150c25ffe6..8a5fc59bb33a 100644
>> --- a/arch/x86/include/uapi/asm/hyperv-tlfs.h
>> +++ b/arch/x86/include/uapi/asm/hyperv-tlfs.h
>> @@ -101,7 +101,7 @@ union hv_partition_processor_features {
>>  		__u64 fsrep_stosb:1;
>>  		__u64 fsrep_cmpsb:1;
>>  		__u64 reserved_bank1:42;
>> -	};
>> +	} __packed;
>>  	__u64 as_uint64[HV_PARTITION_PROCESSOR_FEATURE_BANKS];
>>  };
>>  
>> @@ -111,7 +111,7 @@ union hv_partition_processor_xsave_features {
>>  		__u64 xsaveopt_support : 1;
>>  		__u64 avx_support : 1;
>>  		__u64 reserved1 : 61;
>> -	};
>> +	} __packed;
>>  	__u64 as_uint64;
>>  };
>>  
>> @@ -119,6 +119,6 @@ struct hv_partition_creation_properties {
>>  	union hv_partition_processor_features disabled_processor_features;
>>  	union hv_partition_processor_xsave_features
>>  		disabled_processor_xsave_features;
>> -};
>> +} __packed;
> 
> These hunks should have been squashed to the previous patch. They don't
> belong here.
> 
> Wei.
> 
Yes, I applied these to the wrong patch...oops!