linux-kernel - Re: [PATCH] drivers: crypto: talitos.c: Replace space with tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b25b51d2-df56-31c8-83a7-44c0dac1270d@csgroup.eu>
Date:   Tue, 1 Jun 2021 15:02:52 +0200
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     shubh vk <shubhankarvk@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH] drivers: crypto: talitos.c: Replace space with tabs



Le 25/05/2021 à 20:15, shubh vk a écrit :
> 
> 
> On Tue, 25 May 2021, 9:45 pm Christophe Leroy, <christophe.leroy@...roup.eu 
> <mailto:christophe.leroy@...roup.eu>> wrote:
> 
>     Shubhankar Kuranagatti <shubhankarvk@...il.com <mailto:shubhankarvk@...il.com>> a écrit :
> 
>      > Tabs have been used instead of spaces for indentation
>      > This is done to maintain code uniformity(LINDENT).
> 
>     Nack.
> 
>     The changes done by this patch break linux codying style. For
>     instance, additional lines alignment must match open parenthesis.
> 
>     Did you run checkpatch.pl <http://checkpatch.pl/> on your path?
> 
>     Yes, I have run checkpatch on my file and it showed no errors or warnings.


Surprisingly, checkpatch on your patch doesn't say anything, but checkpatch on 
drivers/crypto/talitos.c after applying your patch returns the following in addition to the ones 
returned without your patch:

CHECK: Alignment should match open parenthesis
#177: FILE: drivers/crypto/talitos.c:177:
+		setbits32(priv->chan[ch].reg + TALITOS_CCCR_LO,
+				TALITOS_CCCR_LO_IWSE);

CHECK: Alignment should match open parenthesis
#252: FILE: drivers/crypto/talitos.c:252:
+		setbits32(priv->reg_mdeu + TALITOS_EUICR_LO,
+				TALITOS_MDEUICR_LO_ICE);





Christophe