linux-kernel - Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Jun 2021 21:04:35 +0800
From:   hongbo li <herbert.tencent@...il.com>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     "open list:ASYMMETRIC KEYS" <keyrings@...r.kernel.org>,
        linux-crypto@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers <ebiggers@...nel.org>,
        David Howells <dhowells@...hat.com>, jarkko@...nel.org,
        herberthbli(李弘博) 
        <herberthbli@...cent.com>,
        open list <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

Hi Tianjia,

Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> 于2021年6月1日周二 上午10:54写道：
>
> Hi Hongbo,
>
> On 5/31/21 9:30 PM, Hongbo Li wrote:
> > From: Hongbo Li <herberthbli@...cent.com>
> >
> > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> > test_akcipher_one(), it will set public key for every test vector,
> > and don't free ec->Q. This will cause a memory leak.
> >
> > This patch alloc ec->Q in sm2_ec_ctx_init().
> >
> > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> > Signed-off-by: Hongbo Li <herberthbli@...cent.com>
> > Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> > ---
> >   crypto/sm2.c | 24 ++++++++++--------------
> >   1 file changed, 10 insertions(+), 14 deletions(-)
> >
>
> Just add Cc: to SOB, like this:
>
>    Fixes: ea7ecb66440b (...)
>    Signed-off-by: Hongbo Li <herberthbli@...cent.com>
>    Cc: stable@...r.kernel.org # v5.10+
>    Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
>
> Thanks,
> Tianjia

Thank you, I will resend the patch.
Hongbo