linux-kernel - Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91999e12-a7de-ad4b-72c4-2376ac682c92@linux.alibaba.com>
Date:   Tue, 1 Jun 2021 10:54:07 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Hongbo Li <herbert.tencent@...il.com>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
        ebiggers@...nel.org, dhowells@...hat.com, jarkko@...nel.org,
        herberthbli@...cent.com
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] crypto: sm2 - fix a memory leak in sm2

Hi Hongbo,

On 5/31/21 9:30 PM, Hongbo Li wrote:
> From: Hongbo Li <herberthbli@...cent.com>
> 
> SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> test_akcipher_one(), it will set public key for every test vector,
> and don't free ec->Q. This will cause a memory leak.
> 
> This patch alloc ec->Q in sm2_ec_ctx_init().
> 
> Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
> Signed-off-by: Hongbo Li <herberthbli@...cent.com>
> Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> ---
>   crypto/sm2.c | 24 ++++++++++--------------
>   1 file changed, 10 insertions(+), 14 deletions(-)
> 

Just add Cc: to SOB, like this:

   Fixes: ea7ecb66440b (...)
   Signed-off-by: Hongbo Li <herberthbli@...cent.com>
   Cc: stable@...r.kernel.org # v5.10+
   Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

Thanks,
Tianjia