linux-kernel - [PATCH] x86/kprobes: remove free_insn_page since it is same with the common weak function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210601040856.22080-1-song.bao.hua@hisilicon.com>
Date:   Tue, 1 Jun 2021 16:08:56 +1200
From:   Barry Song <song.bao.hua@...ilicon.com>
To:     <hpa@...or.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
        <bp@...en8.de>, <x86@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Barry Song <song.bao.hua@...ilicon.com>
Subject: [PATCH] x86/kprobes: remove free_insn_page since it is same with the common weak function

free_insn_page() in x86 is same with the common weak function in
kernel/kprobes.c. Plus, its comment "Recover page to RW mode before
releasing it" seems insensible to be there since resetting mapping
is done by common code in vfree() of module_memfree().
So drop the strong function and its comment in x86 totally.

Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>
---
 arch/x86/kernel/kprobes/core.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index d3d65545cb8b..3bce67d3a03c 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -422,12 +422,6 @@ void *alloc_insn_page(void)
 	return page;
 }
 
-/* Recover page to RW mode before releasing it */
-void free_insn_page(void *page)
-{
-	module_memfree(page);
-}
-
 /* Kprobe x86 instruction emulation - only regs->ip or IF flag modifiers */
 
 static void kprobe_emulate_ifmodifiers(struct kprobe *p, struct pt_regs *regs)
-- 
2.25.1