linux-kernel - Re: [PATCH] x86/kprobes: remove free_insn_page since it is same with the common weak function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YL3VuU/GQl6HWGq7@infradead.org>
Date:   Mon, 7 Jun 2021 09:15:53 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     hpa@...or.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/kprobes: remove free_insn_page since it is same with
 the common weak function

On Tue, Jun 01, 2021 at 04:08:56PM +1200, Barry Song wrote:
> free_insn_page() in x86 is same with the common weak function in
> kernel/kprobes.c. Plus, its comment "Recover page to RW mode before
> releasing it" seems insensible to be there since resetting mapping
> is done by common code in vfree() of module_memfree().
> So drop the strong function and its comment in x86 totally.
> 
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>

It also is the same for s390, so please remove that as well and remove
the __weak.