linux-kernel - Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLe8psfQLCb5bn2W@kroah.com>
Date:   Wed, 2 Jun 2021 19:15:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Manikishan Ghantasala <manikishanghantasala@...il.com>
Cc:     Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue

Why is this line here?

> 
> "Macros with complex values should be enclosed in parentheses"
> by enclosing values in parantheses.

I can not understand this sentence, can you please reword it?

> Modified spacing around "|" and removed a space before tab.

This is not related to the first thing, please break this up into
multiple patches like the bot asked...

thanks,

greg k-h