linux-kernel - Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Jun 2021 23:04:53 +0530
From:   Manikishan Ghantasala <manikishanghantasala@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix coding-style issues in r8192U_hw.h

On Wed, 2 Jun 2021 at 22:45, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Wed, Jun 02, 2021 at 09:33:31PM +0530, Manikishan Ghantasala wrote:
> > staging: rtl8192u: r8192U_hw.h: Clear the coding-style issue
>
> Why is this line here?
>
Added it as description and I put a break due to char limit.
> >
> > "Macros with complex values should be enclosed in parentheses"
> > by enclosing values in parantheses.
>
> I can not understand this sentence, can you please reword it?
>
I meant, I cleared(fixed) the error in quotes by enclosing them in parentheses.

> > Modified spacing around "|" and removed a space before tab.
>
> This is not related to the first thing, please break this up into
> multiple patches like the bot asked...
>
Okay, will do. Do I have to make one for the 'space before tab' too?
or can I ignore it?
> thanks,
>
> greg k-h


Thanks,
Manikishan Ghantasala