| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Jun 2021 16:52:27 +0300
From: Sakari Ailus <sakari.ailus@....fi>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Martin Kepplinger <martin.kepplinger@...i.sm>, mchehab@...nel.org,
devicetree@...r.kernel.org, kernel@...i.sm,
krzysztof.kozlowski@...onical.com, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, paul.kocialkowski@...tlin.com,
robh@...nel.org, shawnx.tu@...el.com
Subject: Re: [PATCH v2 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI
CSI-2 8M pixel sensor
On Fri, May 28, 2021 at 11:35:35AM +0300, Laurent Pinchart wrote:
...
> > + maxItems: 1
> > +
> > + clocks:
> > + description: Reference to the mclk clock.
> > + maxItems: 1
>
> You could also write this
>
> clocks:
> items:
> - description: Reference to the mclk clock.
>
> The maxItems will then be implicit. This is the preferred form when
> multiple clocks are used, and given that clocks it meant to contain a
> list of clocks, even if it has a single entry, placing the description
> in a list of items may be a bit better semantically speaking.
>
> > +
> > + clock-names:
> > + const: mclk
>
> Similarly,
>
> clock-names:
> items:
> - const: mclk
>
> Rob, is standardizing this pattern a good idea, or do you prefer the
> shorter form
>
> clock-names:
> const: mclk
As there's just one clock, isn't the clock-names redundant?
--
Sakari Ailus
Powered by blists - more mailing lists