linux-kernel - Re: [RESEND PATCH net-next v4 0/3] Enable 2.5Gbps speed for stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210603134752.6kjkhzbxmhz3nfyu@skbuf>
Date:   Thu, 3 Jun 2021 16:47:52 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
Cc:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        "Jose.Abreu@...opsys.com" <Jose.Abreu@...opsys.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "Tan, Tee Min" <tee.min.tan@...el.com>,
        "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@...el.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH net-next v4 0/3] Enable 2.5Gbps speed for stmmac

On Thu, Jun 03, 2021 at 01:43:09PM +0000, Sit, Michael Wei Hong wrote:
> Vladimir,
> 
> > -----Original Message-----
> > From: Vladimir Oltean <olteanv@...il.com>
> > Sent: Thursday, June 3, 2021 9:28 PM
> > To: Russell King (Oracle) <linux@...linux.org.uk>
> > Cc: Sit, Michael Wei Hong <michael.wei.hong.sit@...el.com>;
> > Jose.Abreu@...opsys.com; andrew@...n.ch;
> > hkallweit1@...il.com; kuba@...nel.org;
> > netdev@...r.kernel.org; peppe.cavallaro@...com;
> > alexandre.torgue@...s.st.com; davem@...emloft.net;
> > mcoquelin.stm32@...il.com; Voon, Weifeng
> > <weifeng.voon@...el.com>; Ong, Boon Leong
> > <boon.leong.ong@...el.com>; Tan, Tee Min
> > <tee.min.tan@...el.com>; vee.khee.wong@...ux.intel.com;
> > Wong, Vee Khee <vee.khee.wong@...el.com>; linux-stm32@st-
> > md-mailman.stormreply.com; linux-arm-
> > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> > Subject: Re: [RESEND PATCH net-next v4 0/3] Enable 2.5Gbps
> > speed for stmmac
> > 
> > Michael,
> > 
> > On Thu, Jun 03, 2021 at 02:08:51PM +0100, Russell King (Oracle)
> > wrote:
> > > Hi,
> > >
> > > On Thu, Jun 03, 2021 at 07:50:29PM +0800, Michael Sit Wei Hong
> > wrote:
> > > > Intel mGbE supports 2.5Gbps link speed by overclocking the
> > clock
> > > > rate by 2.5 times to support 2.5Gbps link speed. In this mode,
> > the
> > > > serdes/PHY operates at a serial baud rate of 3.125 Gbps and
> > the PCS
> > > > data path and GMII interface of the MAC operate at 312.5
> > MHz instead of 125 MHz.
> > > > This is configured in the BIOS during boot up. The kernel
> > driver is
> > > > not able access to modify the clock rate for 1Gbps/2.5G mode
> > on the
> > > > fly. The way to determine the current 1G/2.5G mode is by
> > reading a
> > > > dedicated adhoc register through mdio bus.
> > >
> > > How does this interact with Vladimir's "Convert xpcs to
> > phylink_pcs_ops"
> > > series? Is there an inter-dependency between these, or a
> > preferred
> > > order that they should be applied?
> > >
> > > Thanks.
> > 
> > My preferred order would be for my series to go in first, if
> > possible, because I don't have hardware readily available to test,
> > and VK already has tested my patches a few times until they
> > reached a stable state.
> > 
> > I went through your patches and I think rebasing on top of my
> > phylink_pcs_ops conversion should be easy.
> > 
> > Thanks.
> Sure! I am okay to let you merge your codes and rebase my changes later on
> Do let me know when I can start rebasing and send in the next revision

Well, you are already copied to my patches, so you should get the
notification email at the same time as I would.
https://patchwork.kernel.org/project/netdevbpf/cover/20210602162019.2201925-1-olteanv@gmail.com/