linux-kernel - Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a1cf301-ba99-1e01-c43e-53b53f4d3e04@oracle.com>
Date:   Thu, 3 Jun 2021 09:48:59 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Russell King <linux@...linux.org.uk>, arm@...nel.org,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Stefan Agner <stefan@...er.ch>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        Stefano Stabellini <sstabellini@...nel.org>
Subject: Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler


On 6/3/21 9:38 AM, Lee Jones wrote:
> On Thu, 03 Jun 2021, Guenter Roeck wrote:
>
>> On Thu, Jun 03, 2021 at 01:43:36PM +0100, Lee Jones wrote:
>>> On Tue, 15 Oct 2019 at 15:52, Thierry Reding <thierry.reding@...il.com>
>>> wrote:
>>>
>>>> From: Guenter Roeck <linux@...ck-us.net>
>>>>
>>>> Register with kernel restart handler instead of setting arm_pm_restart
>>>> directly.
>>>>
>>>> Select a high priority of 192 to ensure that default restart handlers
>>>> are replaced if Xen is running.
>>>>
>>>> Acked-by: Arnd Bergmann <arnd@...db.de>
>>>> Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
>>>> Reviewed-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
>>>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>>> Signed-off-by: Thierry Reding <treding@...dia.com>
>>>> ---
>>>>  arch/arm/xen/enlighten.c | 12 ++++++++++--
>>>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>>>
>>> This patch does appear to be useful.
>>>
>>> Is this just being solved in downstream trees at the moment?
>>>
>>> It would be nice if we could relinquish people of this burden and get it
>>> into Mainline finally.
>>>
>> There must have been half a dozen attempts to send this patch series
>> upstream. I have tried, and others have tried. Each attempt failed with
>> someone else objecting for non-technical reasons (such as "we need more
>> reviews") or no reaction at all, and maintainers just don't pick it up.
> Looking at the *-by tag list above, I think we have enough quality
> reviews to take this forward.
>
>> So, yes, this patch series can only be found in downstream trees,
>> and it seems pointless to submit it yet again.
> IMHO, it's unfair to burden multiple downstream trees with this purely
> due to poor or nervy maintainership.  Functionality as broadly useful
> as this should be merged and maintained in Mainline.
>
> OOI, who is blocking?  As I see it, we have 2 of the key maintainers
> in the *-by list.  With those on-board, it's difficult to envisage
> what the problem is.


Stefano (who is ARM Xen maintainer) left Citrix a while ago. He is at sstabellini@...nel.org (which I added to the CC line).


-boris