linux-kernel - Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLjr6XaK7q3r8dmi@nx64de-df6d00>
Date:   Thu, 3 Jun 2021 16:49:13 +0200
From:   Grzegorz Szymaszek <gszymaszek@...rt.pl>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Grzegorz Szymaszek <gszymaszek@...rt.pl>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Marcin Sloniewski <marcin.sloniewski@...il.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins

Hello Ahmad,

On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote:
> On 03.06.21 16:23, Grzegorz Szymaszek wrote:
> > The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output.
> > stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI
> > interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is
> > incompatible with the pins used on the Odyssey board, where:
> > - there are 8 data pins instead of 12,
> > - […]
> > 
> > Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in
> > the Odyssey device tree.
> 
> Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that
> instead of overriding an existing one.

Can I simply use dcmi_pins_b (as the first unused identifier) or is
there some way to match specific pin groups to an identifier (b, c, d,
and so on)?

> Current convention is also to place all STM32MP1 pinctrl nodes into
> a central file, not in the individual board device trees.

Sure, I will update the patch.

Thanks for your comments!

-- 
Grzegorz