linux-kernel - Re: [PATCH wq/for-next 1/2] workqueue: replace open-coded work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhGHyCq8Zy65XpnH1gFPQKq4+q3GbVAFtpvwz0+mHYqKgaXjw@mail.gmail.com>
Date:   Thu, 3 Jun 2021 10:20:20 +0800
From:   Lai Jiangshan <jiangshanlai@...il.com>
To:     Julian Wiedmann <jwi@...ux.ibm.com>
Cc:     Tejun Heo <tj@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wq/for-next 1/2] workqueue: replace open-coded work_pending()

For both of these patches

Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>


On Wed, Jun 2, 2021 at 7:17 PM Julian Wiedmann <jwi@...ux.ibm.com> wrote:
>
> Use the right helper to check whether a work item is currently pending.
>
> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>
> ---
>  kernel/workqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 50142fc08902..8a700ccfa313 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3209,7 +3209,7 @@ EXPORT_SYMBOL(flush_delayed_work);
>   */
>  bool flush_rcu_work(struct rcu_work *rwork)
>  {
> -       if (test_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(&rwork->work))) {
> +       if (work_pending(&rwork->work)) {
>                 rcu_barrier();
>                 flush_work(&rwork->work);
>                 return true;
> --
> 2.25.1
>