linux-kernel - Re: [PATCH] mm: mempolicy: don't have to split pmd for huge zero page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DC3A8596-DC59-4B3B-8BA9-A0C2432552DF@nvidia.com>
Date:   Fri, 04 Jun 2021 17:23:51 -0400
From:   Zi Yan <ziy@...dia.com>
To:     Yang Shi <shy828301@...il.com>
Cc:     nao.horiguchi@...il.com, mhocko@...e.com,
        kirill.shutemov@...ux.intel.com, hughd@...gle.com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: mempolicy: don't have to split pmd for huge zero page

On 4 Jun 2021, at 16:35, Yang Shi wrote:

> When trying to migrate pages to obey mempolicy, the huge zero page is
> split then the page table walk at PTE level just skips zero page.  So it
> seems pointless to split huge zero page, it could be just skipped like
> base zero page.
>
> Set ACTION_CONTINUE to prevent the walk_page_range() split the pmd for
> this case.
>
> Signed-off-by: Yang Shi <shy828301@...il.com>

LGTM. Thanks.

Reviewed-by: Zi Yan <ziy@...dia.com>


—
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)