linux-kernel - Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3eb7afb6-629e-bac9-9a5b-7626a3f2359b@ti.com>
Date:   Fri, 4 Jun 2021 01:14:56 -0500
From:   Suman Anna <s-anna@...com>
To:     Wilken Gottwalt <wilken.gottwalt@...teo.net>
CC:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, <devicetree@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-sunxi@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in
 binding

On 6/3/21 11:55 PM, Wilken Gottwalt wrote:
> On Thu, 3 Jun 2021 09:42:16 -0500
> Suman Anna <s-anna@...com> wrote:
> 
>> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
>> $id and fails to compile the example due to undefined args specifier
>> values for clocks and resets. Fix both of these issues.
>>
>> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
>> Signed-off-by: Suman Anna <s-anna@...com>
>> ---
>> Hi Wilken,
>>
>> This fixes the warnings for now on linux-next, but I think the example
>> should be including sun6i-a31-ccu.h files instead to be accurate, and
>> those files are missing the definitions for CLK_BUS_SPINLOCK and
>> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
>> patch on top.
>>
>> regards
>> Suman
> 
> Hi Suman,
> 
> thank you for fixing this. I would have fix it the same way for now, so it is
> fine for me. But I will keep an eye on it.

Thanks Will.

Bjorn,
Do ignore the RFC tag then, and you can pick up the patch.

regards
Suman


> 
> greetings,
> Will
> 
>>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index
>> 733c3d01e56c..10e5a53e447b 100644 ---
>> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@
>>  # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>  %YAML 1.2
>>  ---
>> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
>> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>  
>>  title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
>> @@ -36,6 +36,9 @@ additionalProperties: false
>>  
>>  examples:
>>    - |
>> +    #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
>> +    #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
>> +
>>      hwlock@...8000 {
>>          compatible = "allwinner,sun6i-a31-hwspinlock";
>>          reg = <0x01c18000 0x1000>;
>