linux-kernel - Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+mhJgFZniXYTVf5ZEM84APhm2w_ozLJg_pFtgz+W_wYw@mail.gmail.com>
Date:   Mon, 7 Jun 2021 08:19:03 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Suman Anna <s-anna@...com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Wilken Gottwalt <wilken.gottwalt@...teo.net>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
        "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
        <linux-remoteproc@...r.kernel.org>, linux-sunxi@...ts.linux.dev,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding

On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <s-anna@...com> wrote:
>
> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> $id and fails to compile the example due to undefined args specifier
> values for clocks and resets. Fix both of these issues.
>
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> Signed-off-by: Suman Anna <s-anna@...com>
> ---
> Hi Wilken,
>
> This fixes the warnings for now on linux-next, but I think the example
> should be including sun6i-a31-ccu.h files instead to be accurate, and
> those files are missing the definitions for CLK_BUS_SPINLOCK and
> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> patch on top.
>
> regards
> Suman
>
>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@...nel.org>