linux-kernel - Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZEQ+C7tSppcJ83Go70CaBLe4XYKBqYqJfZWAYq-H2+wA@mail.gmail.com>
Date:   Fri, 4 Jun 2021 09:44:59 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Daniel Vetter <daniel@...ll.ch>, Emma Anholt <emma@...olt.net>,
        David Airlie <airlied@...ux.ie>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2] drm/pl111: Actually fix CONFIG_VEXPRESS_CONFIG depends

On Fri, Jun 4, 2021 at 3:41 AM Kees Cook <keescook@...omium.org> wrote:

> VEXPRESS_CONFIG needs to either be missing, built-in, or modular when
> pl111 is modular. Update the Kconfig to reflect the need.
>
> Fixes: 4dc7c97d04dc ("drm/pl111: depend on CONFIG_VEXPRESS_CONFIG")

Yeah that doesn't work, thanks for fixing this!

> Signed-off-by: Kees Cook <keescook@...omium.org>

> -       depends on VEXPRESS_CONFIG
> +       depends on ARM || ARM64 || COMPILE_TEST
> +       depends on VEXPRESS_CONFIG || VEXPRESS_CONFIG=n

That's the right solution,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij