linux-kernel - Re: [PATCH] fsi: core: Fix return of error values on failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc45bf20461fda09e7b224465285f1385cdab09b.camel@ozlabs.org>
Date:   Fri, 04 Jun 2021 09:44:33 +0800
From:   Jeremy Kerr <jk@...abs.org>
To:     Colin King <colin.king@...onical.com>,
        Joel Stanley <joel@....id.au>,
        Alistar Popple <alistair@...ple.id.au>,
        Eddie James <eajames@...ux.ibm.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-fsi@...ts.ozlabs.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi: core: Fix return of error values on failures

Hi Colin,
> Currently the cfam_read and cfam_write functions return the provided
> number of bytes given in the count parameter and not the error return
> code in variable rc, hence all failures of read/writes are being
> silently ignored. Fix this by returning the error code in rc.

Looks good to me, thanks for the fix.

Reviewed-by: Jeremy Kerr <jk@...abs.org>

Cheers,


Jeremy