linux-kernel - Re: [External] [PATCH] mm, hugetlb: fix allocation error check and copy func name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtWf3rx7MT88+t=H=5bVs_yNBFX5YTcWZs7in_+17i7+Fw@mail.gmail.com>
Date:   Sat, 5 Jun 2021 20:49:58 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Mina Almasry <almasrymina@...gle.com>
Cc:     Linux Memory Management List <linux-mm@...ck.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [External] [PATCH] mm, hugetlb: fix allocation error check and
 copy func name

On Sat, Jun 5, 2021 at 9:07 AM Mina Almasry <almasrymina@...gle.com> wrote:
>
> The alloc_huge_page_vma() doesn't return error pointers, it returns
> NULL.
>
> There is an existing migrate_page_copy() which not only copies the page
> contents, but also page state/metadata.  People could get confused that
> 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
> functionality.  Rename to 'copy_huge_page()' to make it less likely
> folks get confused.
>
> Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
> UFFDIO_COPY")

I think the commit id is not stable. So this really should squash
the commit of "mm, hugetlb: fix racy resv_huge_pages underflow
on UFFDIO_COPY". But anyway,

Reviewed-by: Muchun Song <songmuchun@...edance.com>


>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> Cc: linux-mm@...ck.org
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-kernel@...r.kernel.org