linux-kernel - Re: [PATCH] mm, hugetlb: fix allocation error check and copy func name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82674cdb-2b1e-cd12-5e60-8b19f596bf99@oracle.com>
Date:   Mon, 7 Jun 2021 13:32:32 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Mina Almasry <almasrymina@...gle.com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm, hugetlb: fix allocation error check and copy func
 name

On 6/4/21 6:06 PM, Mina Almasry wrote:
> The alloc_huge_page_vma() doesn't return error pointers, it returns
> NULL.
> 
> There is an existing migrate_page_copy() which not only copies the page
> contents, but also page state/metadata.  People could get confused that
> 'migrate_page_copy' and 'migrate_copy_huge_page' do not have the same
> functionality.  Rename to 'copy_huge_page()' to make it less likely
> folks get confused.
> 
> Fixes: 6a0badc266df ("mm, hugetlb: fix racy resv_huge_pages underflow on
> UFFDIO_COPY")
> 
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> Cc: linux-mm@...ck.org
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: linux-kernel@...r.kernel.org
> 
> ---
>  include/linux/migrate.h | 4 ++--
>  mm/hugetlb.c            | 4 ++--
>  mm/migrate.c            | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)

As mentioned by Muchun, Andrew should squash this and original patch.
With the combined patches,

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
-- 
Mike Kravetz