linux-kernel - Re: [PATCH] mm/nommu: unexport do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YLuL1FLms7tnJtlx@casper.infradead.org>
Date:   Sat, 5 Jun 2021 15:36:04 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Liam Howlett <liam.howlett@...cle.com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/nommu: unexport do_munmap()

On Fri, Jun 04, 2021 at 07:40:16PM +0000, Liam Howlett wrote:
> do_munmap() does not take the mmap_write_lock().  vm_munmap() should be
> used instead.

also, do_munmap was unexported for MMU builds back in 2012 by commit
17d1587f553d.

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---
>  mm/nommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 0997ca38c2bd..3a93d4054810 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
>  	delete_vma(mm, vma);
>  	return 0;
>  }
> -EXPORT_SYMBOL(do_munmap);
>  
>  int vm_munmap(unsigned long addr, size_t len)
>  {
> -- 
> 2.30.2
>