linux-kernel - Re: [PATCH] mm/nommu: unexport do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb975b7f-b8f0-dc33-7a5c-c488157ecf6e@redhat.com>
Date:   Wed, 9 Jun 2021 13:18:21 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Liam Howlett <liam.howlett@...cle.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/nommu: unexport do_munmap()

On 04.06.21 21:40, Liam Howlett wrote:
> do_munmap() does not take the mmap_write_lock().  vm_munmap() should be
> used instead.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---
>   mm/nommu.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 0997ca38c2bd..3a93d4054810 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
>   	delete_vma(mm, vma);
>   	return 0;
>   }
> -EXPORT_SYMBOL(do_munmap);
>   
>   int vm_munmap(unsigned long addr, size_t len)
>   {
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb