linux-kernel - Re: [PATCH 1/4] platform/x86: hdaps: Constify static attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f39a247-25ce-03b0-21f2-506bae576117@f-seidel.de>
Date:   Mon, 7 Jun 2021 18:21:09 +0200
From:   Frank Seidel <frank@...eidel.de>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        "David E. Box" <david.e.box@...ux.intel.com>,
        Justin Ernst <justin.ernst@....com>,
        Frank Seidel <frank@...eidel.de>
Cc:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mike Travis <mike.travis@....com>
Subject: Re: [PATCH 1/4] platform/x86: hdaps: Constify static attribute_group
 struct

> The only use of hdaps_attribute_group is to pass its address to
> sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> to const attribute_group structs. Make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Thanks for the patch and keeping me informed.

Reviewed-by: Frank Seidel <frank@...eidel.de>

> ---
>   drivers/platform/x86/hdaps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> index a72270932ec3..9996485f5295 100644
> --- a/drivers/platform/x86/hdaps.c
> +++ b/drivers/platform/x86/hdaps.c
> @@ -462,7 +462,7 @@ static struct attribute *hdaps_attributes[] = {
>   	NULL,
>   };
>   
> -static struct attribute_group hdaps_attribute_group = {
> +static const struct attribute_group hdaps_attribute_group = {
>   	.attrs = hdaps_attributes,
>   };
>   
>