linux-kernel - RE: [PATCH 4/4] x86/platform/uv: Constify static attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jun 2021 14:34:58 +0000
From:   "Ernst, Justin" <justin.ernst@....com>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Frank Seidel <frank@...eidel.de>,
        "David E. Box" <david.e.box@...ux.intel.com>
CC:     Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Travis, Mike" <mike.travis@....com>
Subject: RE: [PATCH 4/4] x86/platform/uv: Constify static attribute_group
 struct

> The only use of base_attr_group and hubless_base_attr_group is to pass
> their addresses to sysfs_create_group() and sysfs_remove_group(), both
> which takes pointers to const attribute_group structs. Make them const
> to allow the compiler to put them in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Thank you for the patch. 

Reviewed-by: Justin Ernst <justin.ernst@....com>

> ---
>  drivers/platform/x86/uv_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/uv_sysfs.c b/drivers/platform/x86/uv_sysfs.c
> index 7badcfa3f384..956a354b57c1 100644
> --- a/drivers/platform/x86/uv_sysfs.c
> +++ b/drivers/platform/x86/uv_sysfs.c
> @@ -778,7 +778,7 @@ static struct attribute *base_attrs[] = {
>  	NULL,
>  };
> 
> -static struct attribute_group base_attr_group = {
> +static const struct attribute_group base_attr_group = {
>  	.attrs = base_attrs
>  };
> 
> @@ -823,7 +823,7 @@ static struct attribute *hubless_base_attrs[] = {
>  	NULL,
>  };
> 
> -static struct attribute_group hubless_base_attr_group = {
> +static const struct attribute_group hubless_base_attr_group = {
>  	.attrs = hubless_base_attrs
>  };
> 
> --
> 2.31.1