linux-kernel - Re: [PATCH v6 8/8] PCI: Change the type of probe argument in reset functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Jun 2021 06:58:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amey Narkhede <ameynarkhede03@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        alex.williamson@...hat.com,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kw@...ux.com, Shanker Donthineni <sdonthineni@...dia.com>,
        Sinan Kaya <okaya@...nel.org>,
        Amey Narkhede <ameynarkhede03@...il.com>
Subject: Re: [PATCH v6 8/8] PCI: Change the type of probe argument in reset
 functions

Hi Amey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on next-20210607]
[cannot apply to pm/linux-next cryptodev/master crypto/master linus/master v5.13-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amey-Narkhede/Expose-and-manage-PCI-device-reset/20210608-022554
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-randconfig-r031-20210607 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ae973380c5f6be77ce395022be40350942260be9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/827552fbc3a1722cd8f6d5e81c4806670fd5545f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Amey-Narkhede/Expose-and-manage-PCI-device-reset/20210608-022554
        git checkout 827552fbc3a1722cd8f6d5e81c4806670fd5545f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/pci/pci.c:5139:4: error: incompatible function pointer types initializing 'int (*)(struct pci_dev *, pci_reset_mode_t)' (aka 'int (*)(struct pci_dev *, enum pci_reset_mode)') with an expression of type 'int (*)(struct pci_dev *, int)' [-Werror,-Wincompatible-function-pointer-types]
           { &pci_dev_acpi_reset, .name = "acpi" },
             ^~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +5139 drivers/pci/pci.c

3ebe7f9f7e4a4f Keith Busch        2014-05-02  5132  
c09bbd373f3e96 Amey Narkhede      2021-06-07  5133  /*
c09bbd373f3e96 Amey Narkhede      2021-06-07  5134   * The ordering for functions in pci_reset_fn_methods is required for
c09bbd373f3e96 Amey Narkhede      2021-06-07  5135   * reset_methods byte array defined in struct pci_dev.
c09bbd373f3e96 Amey Narkhede      2021-06-07  5136   */
c09bbd373f3e96 Amey Narkhede      2021-06-07  5137  const struct pci_reset_fn_method pci_reset_fn_methods[] = {
c09bbd373f3e96 Amey Narkhede      2021-06-07  5138  	{ &pci_dev_specific_reset, .name = "device_specific" },
ccbe2295e8be73 Shanker Donthineni 2021-06-07 @5139  	{ &pci_dev_acpi_reset, .name = "acpi" },
c09bbd373f3e96 Amey Narkhede      2021-06-07  5140  	{ &pcie_reset_flr, .name = "flr" },
c09bbd373f3e96 Amey Narkhede      2021-06-07  5141  	{ &pci_af_flr, .name = "af_flr" },
c09bbd373f3e96 Amey Narkhede      2021-06-07  5142  	{ &pci_pm_reset, .name = "pm" },
c09bbd373f3e96 Amey Narkhede      2021-06-07  5143  	{ &pci_reset_bus_function, .name = "bus" },
c09bbd373f3e96 Amey Narkhede      2021-06-07  5144  };
c09bbd373f3e96 Amey Narkhede      2021-06-07  5145  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36844 bytes)