linux-kernel - Re: [PATCH v6 8/8] PCI: Change the type of probe argument in reset functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3181f83-24a3-9dc5-dd57-abfdef17403d@nvidia.com>
Date:   Mon, 7 Jun 2021 19:44:52 -0500
From:   Shanker R Donthineni <sdonthineni@...dia.com>
To:     Amey Narkhede <ameynarkhede03@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     <alex.williamson@...hat.com>,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kw@...ux.com>, Sinan Kaya <okaya@...nel.org>
Subject: Re: [PATCH v6 8/8] PCI: Change the type of probe argument in reset
 functions

Hi Amey,

On 6/7/21 1:21 PM, Amey Narkhede wrote:
>  int pci_acpi_program_hp_params(struct pci_dev *dev);
>  extern const struct attribute_group pci_dev_acpi_attr_group;
>  void pci_set_acpi_fwnode(struct pci_dev *dev);
> -int pci_dev_acpi_reset(struct pci_dev *dev, int probe);
> +int pci_dev_acpi_reset(struct pci_dev *dev, pci_reset_mode_t mode);
>  #else
>  static inline int pci_dev_acpi_reset(struct pci_dev *dev, int probe)
>  {
Prototype mismatch, build kernel with CONFIG_ACPI=n to catch this issue.