linux-kernel - Re: [PATCH v12 0/3] bio: control bio max size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210607095732.16896-1-nanich.lee@samsung.com>
Date:   Mon,  7 Jun 2021 18:57:32 +0900
From:   Changheun Lee <nanich.lee@...sung.com>
To:     bvanassche@....org
Cc:     Johannes.Thumshirn@....com, alex_y_xu@...oo.ca,
        alim.akhtar@...sung.com, asml.silence@...il.com,
        avri.altman@....com, axboe@...nel.dk, bgoncalv@...hat.com,
        cang@...eaurora.org, damien.lemoal@....com,
        gregkh@...uxfoundation.org, hch@...radead.org, jaegeuk@...nel.org,
        jejb@...ux.ibm.com, jisoo2146.oh@...sung.com,
        junho89.kim@...sung.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, ming.lei@...hat.com,
        mj0123.lee@...sung.com, nanich.lee@...sung.com, osandov@...com,
        patchwork-bot@...nel.org, seunghwan.hyun@...sung.com,
        sookwan7.kim@...sung.com, tj@...nel.org, tom.leiming@...il.com,
        woosung2.lee@...sung.com, yi.zhang@...hat.com,
        yt0928.kim@...sung.com
Subject: Re: [PATCH v12 0/3] bio: control bio max size

> On 6/3/21 10:03 PM, Changheun Lee wrote:
> > bio size can grow up to 4GB after muli-page bvec has been enabled.
> > But sometimes large size of bio would lead to inefficient behaviors.
> > Control of bio max size will be helpful to improve inefficiency.
> > 
> > blk_queue_max_bio_bytes() is added to enable be set the max_bio_bytes in
> > each driver layer. And max_bio_bytes sysfs is added to show current
> > max_bio_bytes for each request queue.
> > bio size can be controlled via max_bio_bytes.
> 
> Where is the version history for this patch series?

Sorry. I didn't know about it. I'll do next. Thank you for advise.

> 
> Has this patch series been tested in combination with dm-crypt?

This patch has been tested in android device. And dm-crypt on the top of scsi
has tested with below scsi modification in VM too.

@@ -1837,6 +1837,8 @@  void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)
	blk_queue_virt_boundary(q, shost->virt_boundary_mask);
	dma_set_max_seg_size(dev, queue_max_segment_size(q));
			 
+	blk_queue_max_bio_bytes(q, queue_max_sectors(q) << SECTOR_SHIFT);
+
	/*
	 * Set a reasonable default alignment:  The larger of 32-byte (dword),
	 * which is a common minimum for HBAs, and the minimum DMA alignment,

> 
> Bart.
> 

Thank you,
Changheun Lee