linux-kernel - Re: [PATCH v4 4/6] reset: Add Delta TN48M CPLD reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+HBbNHQuMf5z3teqgbn4aY6z+AydCwn1THeMJWCp3RafGXv8w@mail.gmail.com>
Date:   Mon, 7 Jun 2021 12:40:13 +0200
From:   Robert Marko <robert.marko@...tura.hr>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        robh+dt@...nel.org, Lee Jones <lee.jones@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Luka Perkov <luka.perkov@...tura.hr>, jmp@...phyte.org,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Donald Buczek <buczek@...gen.mpg.de>
Subject: Re: [PATCH v4 4/6] reset: Add Delta TN48M CPLD reset controller

On Mon, Jun 7, 2021 at 11:23 AM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> Hi Robert,
>
> On Wed, 2021-06-02 at 14:24 +0200, Robert Marko wrote:
> > Delta TN48M CPLD exposes resets for the following:
> > * 88F7040 SoC
> > * 88F6820 SoC
> > * 98DX3265 switch MAC-s
> > * 88E1680 PHY-s
> > * 88E1512 PHY
> > * PoE PSE controller
> >
> > Controller supports only self clearing resets.
> >
> > Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> > ---
> >  drivers/reset/Kconfig       |   9 +++
> >  drivers/reset/Makefile      |   1 +
> >  drivers/reset/reset-tn48m.c | 128 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 138 insertions(+)
> >  create mode 100644 drivers/reset/reset-tn48m.c
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 4171c6f76385..14e179cda58c 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -237,6 +237,15 @@ config RESET_TI_SYSCON
> >         you wish to use the reset framework for such memory-mapped devices,
> >         say Y here. Otherwise, say N.
> >
> > +config RESET_TN48M_CPLD
> > +     tristate "Delta Networks TN48M switch CPLD reset controller"
> > +     depends on MFD_TN48M_CPLD
>
> Let's make this
>
>         depends on MFD_TN48M_CPLD || COMPILE_TEST
>         default MFD_TN48M_CPLD

Sure, I will change that and send a v5.
>
> unless there is a reason not to enable the reset driver by default when
> the MFD driver is activated.

No, it's just a habit of making everything optional.

Regards,
Robert
>
> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
>
> regards
> Philipp



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@...tura.hr
Web: www.sartura.hr