linux-kernel - Re: [PATCH] TDA1997x: enable EDID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbb99d7b-18eb-317c-911a-b982486848fa@xs4all.nl>
Date:   Mon, 7 Jun 2021 13:11:54 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Krzysztof Hałasa <khalasa@...p.pl>,
        Tim Harvey <tharvey@...eworks.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] TDA1997x: enable EDID support

Hi Krzysztof,

On 07/06/2021 12:56, Krzysztof Hałasa wrote:
> Without this patch, the TDA19971 chip's EDID is inactive.

Was this wrong from the very beginning? How can this ever have been tested
without an EDID?

If it broke in a later patch, then please add a Fixes tag.

Regards,

	Hans

> 
> Signed-off-by: Krzysztof Halasa <khalasa@...p.pl>
> 
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -2233,6 +2233,7 @@ static int tda1997x_core_init(struct v4l2_subdev *sd)
>  	/* get initial HDMI status */
>  	state->hdmi_status = io_read(sd, REG_HDMI_FLAGS);
>  
> +	io_write(sd, REG_EDID_ENABLE, EDID_ENABLE_A_EN | EDID_ENABLE_B_EN);
>  	return 0;
>  }
>  
>