[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb76f83c-e9d1-9726-ff8d-8d48a4de8e26@linux.intel.com>
Date: Mon, 7 Jun 2021 09:43:02 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: "Lu, Brent" <brent.lu@...el.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@...el.com>,
"R, Dharageswari" <dharageswari.r@...el.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Tzung-Bi Shih <tzungbi@...gle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Jie Yang <yang.jie@...ux.intel.com>,
Takashi Iwai <tiwai@...e.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
"Zhi, Yong" <yong.zhi@...el.com>, Mark Brown <broonie@...nel.org>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
"M, Naveen" <naveen.m@...el.com>,
"Wang, Rander" <rander.wang@...el.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Fred Oh <fred.oh@...ux.intel.com>,
"Gopal, Vamshi Krishna" <vamshi.krishna.gopal@...el.com>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@...el.com>
Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for
jsl_cs4242_mx98360a
On 6/7/21 9:29 AM, Lu, Brent wrote:
>> On 6/5/21 7:41 PM, Brent Lu wrote:
>>> This patch adds driver data for jsl_cs4242_mx98360a which supports two
>>> max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on
>>> SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682
>>> machine driver to reuse the topology.
>>
>> This also looks like we have two topologies configuring the same DAIs
>> differently on different platforms.
>>
>> Why can't we pick one configuration that would work in all cases?
>>
>
> The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg.
> This patch does not care about the dai sequence. Maybe I should reword the
> commit log.
I was referring to the bclk frequency, one case uses 2.4 and the other
3.072MHz.
Powered by blists - more mailing lists