linux-kernel - Re: [PATCH -next] pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Jun 2021 11:22:04 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     <linus.walleij@...aro.org>, <radim.pavlik@...-biometrics.com>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] pinctrl: mcp23s08: Fix missing unlock on error in
 mcp23s08_irq()



On 2021/6/7 20:44, Zou Wei wrote:
> Add the missing unlock before return from function mcp23s08_irq()
> in the error handling case.
> 
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>   drivers/pinctrl/pinctrl-mcp23s08.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
> index 799d596..e12aa09 100644
> --- a/drivers/pinctrl/pinctrl-mcp23s08.c
> +++ b/drivers/pinctrl/pinctrl-mcp23s08.c
> @@ -353,6 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
>   
>   	if (intf == 0) {
>   		/* There is no interrupt pending */
> +		goto unlock;
>   		return IRQ_HANDLED;
One mistake here is to forget to delete the "return IRQ_HANDLED" line, 
please ignore this patch, I will send v2 later.
>   	}
>   
>