linux-kernel - Re: [PATCH] f_ncm: ncm_bitrate (speed) is unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Jun 2021 10:44:02 +0900
From:   Lorenzo Colitti <lorenzo@...gle.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Brooke Basile <brookebasile@...il.com>,
        "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yauheni Kaliuta <yauheni.kaliuta@...ia.com>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] f_ncm: ncm_bitrate (speed) is unsigned

On Tue, Jun 8, 2021 at 9:53 AM Maciej Żenczykowski
<zenczykowski@...il.com> wrote:
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm)
>                 data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
>                 data[1] = data[0];
>
> -               DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
> +               DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
>                 ncm->notify_state = NCM_NOTIFY_CONNECT;
>                 break;
>         }

Acked-By: Lorenzo Colitti <lorenzo@...gle.com>