linux-kernel - Re: [PATCH -next v2] misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9fa4670-51d1-0629-8514-941defeb283e@broadcom.com>
Date:   Wed, 9 Jun 2021 08:59:02 -0700
From:   Scott Branden <scott.branden@...adcom.com>
To:     Baokun Li <libaokun1@...wei.com>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     weiyongjun1@...wei.com, yuehaibing@...wei.com,
        yangjihong1@...wei.com, yukuai3@...wei.com,
        bcm-kernel-feedback-list@...adcom.com,
        kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>,
        desmond.yan@...adcom.com
Subject: Re: [PATCH -next v2] misc: bcm-vk: use list_move_tail instead of
 list_del/list_add_tail in bcm_vk_msg.c

On 2021-06-09 12:14 a.m., Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
Acked-by: Scott Branden <scott.branden@...adcom.com>
> ---
> V1->V2:
> 	CC mailist
> 
>  drivers/misc/bcm-vk/bcm_vk_msg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c
> index 6efc52b49af6..066b9ef7fcd7 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_msg.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c
> @@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev,
>  	for (num = 0; num < chan->q_nr; num++) {
>  		list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) {
>  			if ((!ctx) || (entry->ctx->idx == ctx->idx)) {
> -				list_del(&entry->node);
> -				list_add_tail(&entry->node, &del_q);
> +				list_move_tail(&entry->node, &del_q);
>  			}
>  		}
>  	}
> 


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)