linux-kernel - Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in bcm2835_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca893045-7325-d089-c4b2-5d089a0a0bd8@broadcom.com>
Date:   Wed, 9 Jun 2021 08:58:11 -0700
From:   Scott Branden <scott.branden@...adcom.com>
To:     Zhihao Cheng <chengzhihao1@...wei.com>, jaswinder.singh@...aro.org,
        eric@...olt.net, jassisinghbrar@...il.com
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, yukuai3@...wei.com
Subject: Re: [PATCH] mailbox: bcm2835: Remove redundant dev_err call in
 bcm2835_mbox_probe()

On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> 在 2021/6/1 16:24, Zhihao Cheng 写道:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
Acked-by: Scott Branden <scott.branden@...adcom.com>
>> ---
>>   drivers/mailbox/bcm2835-mailbox.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-mailbox.c
>> index 39761d190545..86b7ce3549c5 100644
>> --- a/drivers/mailbox/bcm2835-mailbox.c
>> +++ b/drivers/mailbox/bcm2835-mailbox.c
>> @@ -157,7 +157,6 @@ static int bcm2835_mbox_probe(struct platform_device *pdev)
>>       mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>>       if (IS_ERR(mbox->regs)) {
>>           ret = PTR_ERR(mbox->regs);
>> -        dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>>           return ret;
>>       }
>>   
> 
> friendly ping.
> 


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)