linux-kernel - Re: [PATCH v7 8/8] PCI: Change the type of probe argument in reset functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210525190757.GA25307@raphael-debian-dev>
Date:   Wed, 9 Jun 2021 21:40:03 +0000
From:   Raphael Norwitz <raphael.norwitz@...anix.com>
To:     Amey Narkhede <ameynarkhede03@...il.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kw@...ux.com" <kw@...ux.com>,
        Shanker Donthineni <sdonthineni@...dia.com>,
        Sinan Kaya <okaya@...nel.org>, Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v7 8/8] PCI: Change the type of probe argument in reset
 functions

On Tue, Jun 08, 2021 at 11:18:57AM +0530, Amey Narkhede wrote:
> Introduce a new enum pci_reset_mode_t to make the context of probe argument
> in reset functions clear and the code easier to read.
> Change the type of probe argument in functions which implement reset
> methods from int to pci_reset_mode_t to make the intent clear.
> 
> Add a new line in return statement of pci_reset_bus_function().
> 
> Suggested-by: Alex Williamson <alex.williamson@...hat.com>
> Suggested-by: Krzysztof Wilczyński <kw@...ux.com>
> Signed-off-by: Amey Narkhede <ameynarkhede03@...il.com>

Reviewed-by: Raphael Norwitz <raphael.norwitz@...anix.com>

> ---
>  drivers/crypto/cavium/nitrox/nitrox_main.c    |  2 +-
>  .../ethernet/cavium/liquidio/lio_vf_main.c    |  2 +-
>  drivers/pci/hotplug/pciehp.h                  |  2 +-
>  drivers/pci/hotplug/pciehp_hpc.c              |  4 +-
>  drivers/pci/pci-acpi.c                        | 10 ++-
>  drivers/pci/pci.c                             | 85 ++++++++++++-------
>  drivers/pci/pci.h                             | 12 +--
>  drivers/pci/pcie/aer.c                        |  2 +-
>  drivers/pci/quirks.c                          | 37 ++++----
>  include/linux/pci.h                           |  8 +-
>  include/linux/pci_hotplug.h                   |  2 +-
>  11 files changed, 101 insertions(+), 65 deletions(-)