linux-kernel - Re: [PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Jun 2021 13:09:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Sam Ravnborg <sam@...nborg.org>,
        Rob Clark <robdclark@...omium.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Stanislav Lisovskiy <stanislav.lisovskiy@...el.com>,
        Steev Klimaszewski <steev@...i.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Thierry Reding <treding@...dia.com>,
        Lyude Paul <lyude@...hat.com>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Robert Foss <robert.foss@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 10/11] drm/bridge: ti-sn65dsi86: Improve probe errors
 with dev_err_probe()

On Mon, Jun 7, 2021 at 7:06 PM Douglas Anderson <dianders@...omium.org> wrote:

> As I was testing to make sure that the DEFER path worked well with my
> patch series, I got tired of seeing this scary message in my logs just
> because the panel needed to defer:
>   [drm:ti_sn_bridge_probe] *ERROR* could not find any panel node
>
> Let's use dev_err_probe() which nicely quiets this error and also
> simplifies the code a tiny bit. We'll also update other places in the
> file which can use dev_err_probe().
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij