linux-kernel - Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to __assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210610103344.55f6cf51@oasis.local.home>
Date:   Thu, 10 Jun 2021 10:33:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [for-next][PATCH 11/11] treewide: Add missing semicolons to
 __assign_str uses

On Wed, 09 Jun 2021 19:46:16 -0700
Joe Perches <joe@...ches.com> wrote:

> > diff --git a/net/mac80211/trace.h b/net/mac80211/trace.h  
> []
> > @@ -33,7 +33,7 @@
> >  			__string(vif_name, sdata->name)
> >  #define VIF_ASSIGN	__entry->vif_type = sdata->vif.type; __entry->sdata = sdata;	\
> >  			__entry->p2p = sdata->vif.p2p;					\
> > -			__assign_str(vif_name, sdata->name)
> > +			__assign_str(vif_name, sdata->name);  
> 
> This one is unnecessary as every use of VIF_ASSIGN already has a semicolon
> termination.
> 

Care to send me a v2 of your patch then?

-- Steve